feat(security): add sanitized command preview before scan execution#182
Open
aaniya22 wants to merge 8 commits into
Open
feat(security): add sanitized command preview before scan execution#182aaniya22 wants to merge 8 commits into
aaniya22 wants to merge 8 commits into
Conversation
71155ca to
11a3b15
Compare
Contributor
Author
|
please review and merge this pr |
1 similar comment
Contributor
Author
|
please review and merge this pr |
utksh1
requested changes
May 22, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
Blocking issues before merge:
- The PR adds an empty file at
frontend/frontend/e2e/scan-workflow.spec.ts(note the duplicatedfrontend/path). Please remove this file and ensure E2E specs live underfrontend/e2e/. - This PR mixes multiple concerns (command preview + reports changes + E2E). Please consider splitting into focused PRs to reduce review/merge conflicts.
Once the stray path is removed and scope is clarified, happy to re-review.
60e63f8 to
c793559
Compare
Signed-off-by: aaniya22 <aaniyaatomar@gmail.com>
Signed-off-by: aaniya22 <aaniyaatomar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Summary
Adds a live sanitized command preview panel to the scan configuration page, so users can see what SecuScan is about to run before submitting — with secrets always redacted.
Changes
frontend/src/utils/commandPreview.ts— utility for redaction, sensitive field detection, and token buildingfrontend/src/components/CommandPreview.tsx— live preview panel componentfrontend/src/api.ts— addedsensitive?andcommand_template?fields to typesfrontend/src/pages/ToolConfig.tsx— wired in the preview panelfrontend/testing/unit/utils/commandPreview.test.ts— 22 unit testsfrontend/testing/unit/pages/ToolConfigDynamic.test.tsx— additional integration testsAcceptance Criteria